Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verbose name to Country model #478

Closed
wants to merge 1 commit into from

Conversation

lb-
Copy link
Member

@lb- lb- commented Feb 7, 2024

  • Supports testing for edge case issues such as #10982 & listing labels

@lb- lb- force-pushed the feature/add-verbose-name-country branch from 96ff2f7 to 657e1b2 Compare February 7, 2024 22:10
- Supports testing for edge case issues such as #10982 & listing labels
@lb- lb- force-pushed the feature/add-verbose-name-country branch from 657e1b2 to 427b57c Compare February 7, 2024 22:14
@lb-
Copy link
Member Author

lb- commented Feb 7, 2024

Screenshots where this is used for reference

Screenshot 2024-02-08 at 8 11 58 am Screenshot 2024-02-08 at 8 11 23 am

Comment on lines +31 to 32
verbose_name = "Country of Origin"
verbose_name_plural = "Countries of Origin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something that's been bugging me for a while in this project, the verbose names shouldn't be title-cased. We should let Django/Wagtail decide when it needs to be capitalised (e.g. using capfirst()), as per Django's recommendation

Would be nice to have one migration that changes this for all models, or maybe even just edit the old migration files as this doesn't really change anything in the database.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, should we close this PR and I can raise an issue for that global change instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a new PR that includes the above change #485.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants