-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix generated enums ordering #4664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughDeterministic ordering added for enum and package generation by collecting and sorting names; TypeScript emitter sorts enum elements and removes a redundant error check; changelog updated to note fixed enum ordering. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Generator
participant Collector
participant Sorter
participant Emitter
Generator->>Collector: collect enum names & package names
Collector->>Sorter: provide collected lists
Sorter->>Sorter: sort names deterministically
Sorter-->>Emitter: return sorted lists
Emitter->>Emitter: emit enums/packages in sorted order
Note over Emitter: Deterministic output across runs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks 🙏 Please could you add an entry to the changelog located at |
|
done |
|



Description
Fixes enum random ordering in generated typescript sources.
Fixes # (issue)
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor.Test Configuration
Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit
Bug Fixes
Chores
Documentation