-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[V3] Add universal link support for macOS #4712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v3-alpha
Are you sure you want to change the base?
Conversation
…nk support on macOS.
WalkthroughRenames the C-exported URL handler from Changes
Sequence Diagram(s)sequenceDiagram
participant Apple as Apple OS
participant Delegate as AppDelegate
participant Go as Go runtime
rect rgb(240, 248, 255)
note over Apple,Delegate: Apple Event (Custom URL Scheme)
Apple->>Delegate: handleGetURLEvent:withReplyEvent:
Delegate->>Go: HandleOpenURL(urlString)
Go->>Go: Parse URL & emit ApplicationLaunchedWithUrl
end
rect rgb(240, 255, 240)
note over Apple,Delegate: Universal Link (NSUserActivity)
Apple->>Delegate: application:continueUserActivity:restorationHandler:
Delegate->>Delegate: confirm NSUserActivityTypeBrowsingWeb & webpageURL
Delegate->>Go: HandleOpenURL(webpageURL)
Go->>Go: Parse URL & emit ApplicationLaunchedWithUrl
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks 🙏 Please could you add an entry to the changelog located at |
|
@leaanthony added |
|
|
Would it be possible to have some short documentation on how to use this feature? I'm ok having that in a later PR if we make a ticket for it 👍 Will be updating the docs significantly over the weekend so I'm ok to delay it 👍 |



Description
This PR backports https://github.com/wailsapp/wails/pull/4693/files to V3
Fixes # (issue)
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor.If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit
New Features
Refactor
✏️ Tip: You can customize this high-level summary in your review settings.