Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate hostname in settings from sync storage into local storage #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Separate hostname in settings from sync storage into local storage #297

wants to merge 1 commit into from

Conversation

Vincevdb1
Copy link

This PR fixes #243 by moving the hostname setting to storage.local to ensure it remains machine-specific and does not sync across browsers.

Changes:

  • Updated getSettings and saveSettings to handle hostname in storage.local.
  • Refactored sendHeartbeats to fetch hostname from storage.local.

@Vincevdb1
refactor: Separate hostname in settings from sync storage into local …
33d1146 
…storage;

- Modify the way settings are retrieved from sync and local storages.
- Make sure the hostname doesn't get in the sync storage but in the local storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent Hostname setting from syncing between browsers
1 participant
@Vincevdb1