Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set go-ethereum back to v1.10.26 #1096

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

richard-ramos
Copy link
Member

This is to avoid having to maintain a separate branch for go1.19.
It also bumps some deps

Sadly enough we have to add back the replace for go-ethereum for it to play nicely with status-go, but since the idea is for this to be replaced by nwaku eventually, i guess it's okay. We should still think of rebasing go-ethereum to a more recent version tho.

@status-im-auto
Copy link

status-im-auto commented May 6, 2024

Jenkins Builds

Click to see older builds (3)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ a721227 #1 2024-05-06 14:26:12 ~15 sec nix-flake 📄log
✔️ f3d9ce4 #2 2024-05-06 15:46:26 ~2 min nix-flake 📄log
✖️ 07aa502 #3 2024-05-06 17:35:50 ~12 sec nix-flake 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 5f89635 #4 2024-05-06 17:45:25 ~12 sec nix-flake 📄log
✔️ 5d73c65 #5 2024-05-06 17:51:23 ~2 min nix-flake 📄log

@richard-ramos richard-ramos force-pushed the chore-go1.20 branch 3 times, most recently from 07aa502 to 5f89635 Compare May 6, 2024 17:44
This is to avoid having to maintain a separate branch for go1.19. It also bumps some deps
@richard-ramos
Copy link
Member Author

ci/test fails due to waku-org/nwaku#2675

@qfrank
Copy link
Collaborator

qfrank commented May 7, 2024

but since the idea is for this to be replaced by nwaku eventually

Do we have a planned date for this? @richard-ramos

@richard-ramos
Copy link
Member Author

@qfrank: Do we have a planned date for this?

No planned date for this, it's something more of a long term plan.

@richard-ramos richard-ramos merged commit 19d27be into master May 7, 2024
12 checks passed
@richard-ramos richard-ramos deleted the chore-go1.20 branch May 7, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants