Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix store request id log #1242

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: fix store request id log #1242

merged 1 commit into from
Oct 21, 2024

Conversation

kaichaosun
Copy link
Contributor

@kaichaosun kaichaosun commented Oct 17, 2024 •
edited
Loading

Fix log format error report by @Ivansete-status

DEBUG[10-16|00:31:04.670|github.com/status-im/status-go/vendor/github.com/waku-org/go-waku/waku/v2/protocol/store/client.go:268]                   sending store request                
    peer=16Uiu2HAmCDSnT8oNpMR9HH6uipD71KstYuDCAQGpek9XDAVmqdEr requestId=386435316230353735323932346531303936666262643339346338356238663965636138383336353037386463333863626561333062316
13839323061613330

Use this code to get correct format before release. https://go.dev/play/p/1L2mA3BzEva

@status-im-auto
Copy link

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 787d54a #1 2024-10-17 03:19:35 ~2 min unknown 📄log

chaitanyaprem
chaitanyaprem approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@chaitanyaprem chaitanyaprem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaichaosun kaichaosun merged commit 38be0dc into master Oct 21, 2024
15 checks passed
@kaichaosun kaichaosun deleted the fix-requestid-log branch October 21, 2024 03:23
@kaichaosun kaichaosun mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaprem chaitanyaprem chaitanyaprem approved these changes

@richard-ramos richard-ramos Awaiting requested review from richard-ramos richard-ramos is a code owner

Assignees

@kaichaosun kaichaosun

Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaichaosun @status-im-auto @chaitanyaprem