Skip to content

chore(sds): allow specifying lookback time range for store query #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore(sds): allow specifying lookback time range for store query #2651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/sdk/src/query_on_connect/query_on_connect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,12 @@ export interface QueryOnConnectOptions {
* @default [[DEFAULT_FORCE_QUERY_THRESHOLD_MS]]
*/
forceQueryThresholdMs?: number;
/**
* Maximum lookback window for the initial store query performed by
* QueryOnConnect when a store peer connects.
* @default [[MAX_TIME_RANGE_QUERY_MS]] (24 hours)
Copy link
Collaborator

@fryorcraken fryorcraken Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that if you use a value over 24hrs, the underlying store protocol will split it in 24 hrs queries.

*/
maxTimeRangeQueryMs?: number;
}

export enum QueryOnConnectEvent {
Expand All @@ -51,6 +57,7 @@ export class QueryOnConnect<
private lastSuccessfulQuery: number;
private lastTimeOffline: number;
private readonly forceQueryThresholdMs: number;
private readonly maxTimeRangeQueryMs: number;

public constructor(
public decoders: IDecoder<T>[],
Expand All @@ -67,6 +74,8 @@ export class QueryOnConnect<
this.lastTimeOffline = 0;
this.forceQueryThresholdMs =
options?.forceQueryThresholdMs ?? DEFAULT_FORCE_QUERY_THRESHOLD_MS;
this.maxTimeRangeQueryMs =
options?.maxTimeRangeQueryMs ?? MAX_TIME_RANGE_QUERY_MS;
}

public start(): void {
Expand Down Expand Up @@ -140,7 +149,7 @@ export class QueryOnConnect<
return calculateTimeRange(
Date.now(),
this.lastSuccessfulQuery,
MAX_TIME_RANGE_QUERY_MS
this.maxTimeRangeQueryMs
);
}

Expand Down
13 changes: 12 additions & 1 deletion packages/sdk/src/reliable_channel/reliable_channel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,12 @@ export type ReliableChannelOptions = MessageChannelOptions & {
* @default 1000 (1 second)
*/
processTaskMinElapseMs?: number;
/**
* Maximum lookback window for the initial store query performed by
* QueryOnConnect when a store peer connects.
* @default 24h
*/
initialQueryLookbackMs?: number;
};

/**
Expand Down Expand Up @@ -190,7 +196,12 @@ export class ReliableChannel<
[this.decoder],
peerManagerEvents,
node.events,
this._retrieve.bind(this)
this._retrieve.bind(this),
{
maxTimeRangeQueryMs: options?.initialQueryLookbackMs,
// Keep existing default unless user overrides
forceQueryThresholdMs: undefined
}
);
}
}
Expand Down
Loading