-
Notifications
You must be signed in to change notification settings - Fork 49
feat: add SDS-Repair (SDS-R) to the SDS implementation #2698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@waku-org/js-waku Not directly related to SDS-R, but I'm a bit nervous about collections that seemingly grow without being capped. Specifically the |
size-limit report 📦
|
|
Parallel pull request for SDS-R in reliable channels: #2701 (will open for review once this one is merged) |
Co-authored-by: Sasha <[email protected]> Co-authored-by: fryorcraken <[email protected]>
weboko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, nice PR!
do you want me to make a testing release of SDS library for you?
Will be useful for the reliable channels integration, I think. |
|
You can use @waku/sdk with version 0.0.36-3288d28.0 Published here https://github.com/waku-org/js-waku/actions/runs/18852649975/job/53792729460 |
Adds SDS-R capability to the SDS implementation, following https://rfc.vac.dev/vac/raw/sds#sds-repair-sds-r
Integration into reliable channels is following closely behind (I'll open a separate PR).
Will appreciate any feedback, also suggestions on following idiomatic ts (or js-waku) practices.
@fryorcraken I've kept the SDS-R-Implementation-Guide.md in the branch for now, but presumably the idea is to adapt its content to the Implementation Suggestions section of the spec and remove from the js-waku repo?