feat: persistent history for SDS #2741
Draft
+293
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fryorcraken
reviewed
Nov 15, 2025
| * | ||
| * If no storage backend is available, this behaves like {@link MemLocalHistory}. | ||
| */ | ||
| export class PersistentHistory extends MemLocalHistory { |
Collaborator
There was a problem hiding this comment.
Why are you extending another class instead of the interface? Avoid abstractions as a rule of thumb
Collaborator
Author
There was a problem hiding this comment.
extended so that we could get the implementations for the following functions without needing to reimplement:
push(...items: ContentMessage[]): number;
some(
predicate: (
value: ContentMessage,
index: number,
array: ContentMessage[]
) => unknown,
thisArg?: any
): boolean;
slice(start?: number, end?: number): ContentMessage[];
find(
predicate: (
value: ContentMessage,
index: number,
obj: ContentMessage[]
) => unknown,
thisArg?: any
): ContentMessage | undefined;
findIndex(
predicate: (
value: ContentMessage,
index: number,
obj: ContentMessage[]
) => unknown,
thisArg?: any
): number;| this.restore(); | ||
| } | ||
|
|
||
| public override push(...items: ContentMessage[]): number { |
Collaborator
There was a problem hiding this comment.
Yeah, don't use abstraction. Its not worth the indirection you are bringing in
Collaborator
Author
There was a problem hiding this comment.
switched to composition!
| } | ||
|
|
||
| private persist(): void { | ||
| if (!this.storage) { |
Collaborator
There was a problem hiding this comment.
Hum, does it make sense for it to be constructed without storage?
Collaborator
Author
There was a problem hiding this comment.
we want the class to behave like MemLocalHistory if no storage is provided, right?
fryorcraken
reviewed
Nov 15, 2025
fryorcraken
reviewed
Nov 15, 2025
…istentHistory` to use composition over inheritance for history management.
…e key generation.
…ifying history storage initialization to default to `localStorage`
danisharora099
force-pushed
the
feat/persistent_history
branch
from
d7aa504 to
92dd0ba
Compare
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Description
Solution
Notes
Checklist