Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-relay): resultify rln-relay 1/n #2607

Merged
merged 12 commits into from
Apr 26, 2024
Merged

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Apr 19, 2024

Description

This PR begins work on resultifying rln-relay. We start with the mount process, which includes a lot of procedures internally that were resultified. Following PRs will address the rest.
After it is fully removed, some templates like initializedGuard and retryWrapped will be refactored and removed.

Changes

  • resultified rln-relay mount
  • resultified group manager init, startGroupSync and initializedGuards

Copy link

github-actions bot commented Apr 19, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2607-rln-v2-true

Built from dc49967

@rymnc rymnc marked this pull request as ready for review April 22, 2024 10:41
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much for that step further extending the resultify approach :D 🥳

Copy link

github-actions bot commented Apr 22, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2607-rln-v1

Built from 41dd2b5

Copy link

github-actions bot commented Apr 22, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2607-rln-v2

Built from 41dd2b5

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazingg, thank you! Just added a small q :))

@rymnc rymnc requested a review from gabrielmer April 25, 2024 10:12
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superr, thanks so much!

@rymnc rymnc merged commit 1d7ff28 into master Apr 26, 2024
13 of 15 checks passed
@rymnc rymnc deleted the resultify-waku-rln-relay branch April 26, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants