refactor: REST - create rest/builder.nim and simplify factory/app.nim #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
changed the title
|
You can find the image built from this PR at Built from 60568ac |
Ivansete-status
requested review from
NagyZoltanPeter,
SionoiS,
jm-clius and
gabrielmer
NagyZoltanPeter
requested changes
Apr 22, 2024
There was a problem hiding this comment.
I think we are crossing our works. Can you please take a look at mine. I will draft it now. I'm just adding a final json serialization for a bit extended /health endpoint.
To enable separation of initialization health from other endpoints and start rest server earlier, I needed to rework to order of rest initialization.
Still, I agree to simplify waku node initialization order due I found its overly complicated.
gabrielmer
reviewed
Apr 22, 2024
|
Closing because has been solved in #2623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract some REST logic from app.nim, aiming for simplify
app.nima little.I will submit a couple of similar PRs simplifying
app.nim.Issue
With that simplification, this PR indirectly contributes to the following: migrate DiscV5 and DNS Discovery from app.nim to waku_node.nim #2452