Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rln-db-inspector): add more logging to find zero leaf indices #2617

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Apr 23, 2024

Description

This PR adds logs to the rln-db-inspector which allows to find indices in the tree that have not been set.

Changes

  • Checks if a leaf is zero, if it is, then adds to array
  • assumeEmptyAfter is set to 10

Copy link

github-actions bot commented Apr 23, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2617-rln-v2

Built from 8911348

Copy link

github-actions bot commented Apr 23, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2617-rln-v1

Built from 8911348

@rymnc rymnc marked this pull request as ready for review April 23, 2024 11:56
@rymnc
Copy link
Contributor Author

rymnc commented Apr 23, 2024

image

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rymnc rymnc merged commit 40752b1 into master Apr 24, 2024
13 of 15 checks passed
@rymnc rymnc deleted the add-more-logging-torln-db branch April 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants