fix: content_script_version_4.nim: migration failed when dropping unexisting constraint

[Ivansete-status]

Description

There appeared Postgres schema migration issue when going from schema version 3 to 4.

The problem occurred while trying to remove an index that doesn't seem to exist in version 3.

Aside from that, I'm adding the following line, which is part of the script for version 3, to make sure that index is created in case it doesn't exist. I've notice that when testing in waku.test:
CREATE INDEX IF NOT EXISTS i_query ON messages (contentTopic, pubsubTopic, storedAt, id);

[SionoiS]

I don't understand. The logs seams to suggest that the error happen because messages table already existed.

I don't see how this PR would fix that?

There's 4 cases here, messages and messages_backup both can either exist or not. If we don't handle all cases then it can fail.

[NagyZoltanPeter]

I don't understand. The logs seams to suggest that the error happen because messages table already existed.

I don't see how this PR would fix that?

There's 4 cases here, messages and messages_backup both can either exist or not. If we don't handle all cases then it can fail.

Yeah, I agree with SP, the issue here that the migration failed at a stage when both table existed. Dropping the constraint will not solve this.
Or do you think the original issue with the migration happened because the existed constraint?

[Ivansete-status]

Yes sorry for the confusion guys. I will unset you from reviewers until I have a better fix.
Thanks for the comments!

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2672-rln-v1

Built from ebcd370

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2672-rln-v2

Built from ebcd370

[SionoiS]

Based on your description of the problem this seams good.

Thanks

[gabrielmer]

LGTM, thanks so much! 😍