Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rln-relay): use arkzkey variant of zerokit #2681

Merged
merged 1 commit into from
May 17, 2024

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented May 8, 2024

Description

This PR includes the new zerokit release v0.4.4, which brings a speedup of ~50% while running tests and deserialization for the circuit logic.

Changes

  • updated Makefile entry
  • updated build_rln.sh to use arkzkey if version is v0.4.4

Comparison

While running tests/waku_rln_relay/test_all.nim with RLN_V2 enabled

Without arkzkey: [Summary] 68 tests run (377.2s): 68 OK, 0 FAILED, 0 SKIPPED
With arkzkey: [Summary] 68 tests run (219.9s): 68 OK, 0 FAILED, 0 SKIPPED

@rymnc rymnc self-assigned this May 8, 2024
Copy link

github-actions bot commented May 8, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2681-rln-v2

Built from 35c649b

Copy link

github-actions bot commented May 8, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2681-rln-v1

Built from 35c649b

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! 💯

@gabrielmer gabrielmer self-requested a review May 17, 2024 09:16
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@rymnc rymnc merged commit e7b0777 into master May 17, 2024
15 of 16 checks passed
@rymnc rymnc deleted the use-arkzkey-variant-of-zerokit branch May 17, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants