feat: Added message size check before relay for lightpush #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 241ef99 |
|
You can find the image built from this PR at Built from 241ef99 |
shash256
requested review from
s-tikhomirov,
jm-clius,
gabrielmer and
NagyZoltanPeter
gabrielmer
approved these changes
May 14, 2024
jm-clius
approved these changes
May 14, 2024
waku/node/waku_node.nim
Outdated
| let validationRes = await node.wakuRelay.validateMessage(pubSubTopic, message) | ||
| if validationRes.isErr(): | ||
| return err(validationRes.error) | ||
| else: |
There was a problem hiding this comment.
Since you return in the previous line, I don't think this else is necessary. In other words, if validation failed, this block of code will not be executed, whether in an else block or not.
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added setup for message validation for lightpush service nodes to catch validation failures before relay. Fixes issue #2595 . Followup to PR #2671 .
Changes