chore: Bump dependencies for v0.34 #3096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 51bd18e |
Bump nim-web3, nim-eth and deps - on_chain/group_manager.nim adaption
Added status-im/nim-minilru submodule required by latest nim-eth
Added nim-quic and nim-ngtcp2 as new deps of nim-libp2p
Fixing tests.
Changes:
modified: .gitmodules
modified: tests/waku_discv5/utils.nim
modified: tests/waku_enr/utils.nim
modified: tests/waku_rln_relay/test_rln_group_manager_onchain.nim
modified: tests/waku_rln_relay/utils.nim
modified: tests/waku_rln_relay/utils_onchain.nim
modified: vendor/nim-chronicles
modified: vendor/nim-eth
modified: vendor/nim-http-utils
modified: vendor/nim-json-rpc
modified: vendor/nim-json-serialization
modified: vendor/nim-libp2p
modified: vendor/nim-metrics
new file: vendor/nim-minilru
modified: vendor/nim-nat-traversal
new file: vendor/nim-ngtcp2
modified: vendor/nim-presto
new file: vendor/nim-quic
modified: vendor/nim-secp256k1
modified: vendor/nim-serialization
modified: vendor/nim-stew
modified: vendor/nim-taskpools
modified: vendor/nim-testutils
modified: vendor/nim-toml-serialization
modified: vendor/nim-unicodedb
modified: vendor/nim-unittest2
modified: vendor/nim-web3
modified: vendor/nim-websock
modified: vendor/nim-zlib
modified: vendor/nimcrypto
modified: waku.nimble
modified: waku/common/enr/builder.nim
modified: waku/common/enr/typed_record.nim
modified: waku/common/utils/nat.nim
modified: waku/discovery/waku_discv5.nim
modified: waku/waku_rln_relay/conversion_utils.nim
modified: waku/waku_rln_relay/group_manager/on_chain/group_manager.nim
modified: waku/waku_rln_relay/rln/wrappers.nim
modified: waku/waku_rln_relay/rln_relay.nim
NagyZoltanPeter
force-pushed
the
bump-dependencies-for-v0.34
branch
from
dd30711
to
7f1ea08
Compare
NagyZoltanPeter
requested review from
Ivansete-status,
gabrielmer,
SionoiS and
alrevuelta
…ting import from json_rpc instead of using std/json
|
Can I review or do the tests need fixing first? @NagyZoltanPeter |
jangko
reviewed
Oct 29, 2024
|
|
||
| var events = newJArray() | ||
| for eventStr in eventStrs: | ||
| events.add(parseJson($eventStr)) |
There was a problem hiding this comment.
I don't know where the dollar come from. But to be on safe side:
var events = newJArray()
for eventStr in eventStrs:
events.add(parseJson(eventStr.string))There was a problem hiding this comment.
Probably I overlooked it as a leftover here. Thanks for it.
…ction success in register
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prepare for v0.34.0
Bumping versions of vendor libs.
Main feature is bumping nim-web3 (and dependencies), nim-eth changes, long time had not been elevated.
This involved due to dependent changes to make json-rpc up to date as well.
By updating nim-libp2p we needed to add nim-quic and nim-ngtcp2 submodules.
Changes
Due to the huge refactorings in nim-web3 and nim-eth modules:
Code changes:
Test changes:
Issue
#3087