chore: returning seqs in libwaku as comma separated strings #3121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In libwaku, when returning sequences as outputs, in some places we are returning the sequence as a comma-separated string such as in
nwaku/library/waku_thread/inter_thread_communication/requests/peer_manager_request.nim
Lines 79 to 90 in 18c375a
while in others we return a string wrapped with the
[ ]
characters, representing an arrayFor the sake of simplicity and consistence - and mainly so the parsing client-side can be the same in all cases - I propose to return all sequences as comma-separated strings
Changes
RETRIEVE_LISTENING_ADDRESSES
as comma-separated stringGET_BOOTSTRAP_NODES
as comma-separated stringIssue
#3115