refactor: adapt sonda setup for deployment #3151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from e486b5e |
Ivansete-status
approved these changes
Oct 25, 2024
| @@ -179,21 +181,20 @@ def main(): | |||
| log_with_utc(f'Store nodes to query: {store_nodes}') | |||
|
|
|||
| # Start Prometheus HTTP server at port 8004 | |||
| start_http_server(8004) | |||
| start_http_server(args.metrics_port) | |||
There was a problem hiding this comment.
Maybe adapt the previous comment too?
There was a problem hiding this comment.
I am not sure what you mean by this?
There was a problem hiding this comment.
Oh you mean to adapt the comment in the script, sure
| @@ -25,6 +26,7 @@ x-sonda-env: &sonda_env | |||
| services: | |||
| nwaku: | |||
| image: ${NWAKU_IMAGE:-harbor.status.im/wakuorg/nwaku:v0.30.1} | |||
| container_name: nwaku | |||
There was a problem hiding this comment.
( comment related to the previous line )
I think we can use a generic tag in the previous line so that the nwaku node version is updated automatically. For example, we could use: harbor.status.im/wakuorg/nwaku:deploy-status-prod
markoburcul
force-pushed
the
modify-sonda-setup
branch
2 times, most recently
from
5b03da1
to
96731d6
Compare
Referenced issue: status-im/infra-hq#135 Signed-off-by: markoburcul <[email protected]>
markoburcul
force-pushed
the
modify-sonda-setup
branch
from
96731d6
to
1f6c8b2
Compare
gabrielmer
approved these changes
Oct 25, 2024
markoburcul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issue: https://github.com/status-im/infra-hq/issues/135
Description
Adapted Sonda script and docker setup to work both for local use and for deployment.
Changes
How to test
Issue
https://github.com/status-im/infra-hq/issues/135