Fix Bankdata: DHL requires an specific order #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move note between iban and bic, else DHL fails with „Bank details are missing“
alexkops
pushed a commit
that referenced
this pull request
Jan 8, 2014
Fix Bankdata: DHL requires an specific order
|
It's very weird that the order of elements matters. Anyway, I'll merge it in. |
|
Yep, that costed me some hours yesterday. Thanks for the merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like DHL has changed something in their Cash On Delivery implementation while enabling BIC and IBAN.
The field
noteMUST be between IBAN and BIC, else you get a weird „Bank details are missing“ error from their server.This pull request fixes the order of the submitted fields.