Fixes to actionbar/TTS misplacement#1487
Merged
Strubbl merged 2 commits intowallabag:masterfrom Dec 17, 2025
Merged
Conversation
Contributor
|
Thank you for your efforts. I usually do not use TTS. How can i test your changes? In the article view with enabling TTS only? Or is there any special action which i shall test? If it works and i can follow your change done, i can review and merge your PR. |
Contributor
Author
@nvllz Thanks for help fixing this. I cloned your repo, checked out your branch and created a build and tested in an emulator. The TTS toolbar issue has been fixed, and the auto hide toolbar still worked as expected as shown in the screenshot. |
Strubbl
approved these changes
Dec 17, 2025
Contributor
|
Also works with my mobile. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Okay, I finally found some time and tried to fix my previous efforts. TTS widget is back at the bottom and actionbar hides properly for me. If there's still any problem on your side pls feed me with more details: your device specs and screen recording or something.
@KevinSJ @Strubbl I want you to test it and let me know if it's fine, but plsss don't make me wait few more months..
It won't be any smoother I think, all the code is sooo old I can't even get myself to rewrite it. Took me a good hour of work to fix a few lines
Here's a zipped debug apk, tested on s20+ (a13) and s25 (a16):
app-debug.zip