Skip to content

wam3483/IMCTaxCalcService

Repository files navigation

IMCTaxCalcService

Thanks kindly for taking the time to review my solution, I appreciate it.

Some assumptions I made which I'd normally discuss with my product owner, and architecture is considering which values TaxJar supports should be exposed on my service contract. If there are concepts TaxJar supports which aren't supported on other calculators, we may consider dropping those values entirely if there's not a strong business need. This is much easier to do if you know all APIs you intend to integrate with up front.

Notes:

  • To test, just launch the solution and use the swagger testing page.
  • Service is OpenAPI/Swagger enabled
  • Service supports versioning
  • Uncaught exception handling via MS logging framework
  • Decorator pattern for tax client tracing, factory pattern for client construction based on user, Dependency injection via MS DI (have used both MS' framework and ninject on .net framework projects)
  • Separations between layers of app down to DTOs/app objects (tax calc service DTOs, TaxClient contract app objects, TaxJar integration DTOs)
  • There are at least 2 unit tests I didn't write due to unexpected things coming up at home. Hopefully I sufficiently demonstrated understanding of unit testing.

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published

Contributors 2

  •  
  •  

Languages