-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support to pull CA Certs from configMap #255
base: main
Are you sure you want to change the base?
Conversation
4bce69b
to
9398d67
Compare
9398d67
to
214ec8d
Compare
support for Parquet to pull ca certs from configmap can be added after this PR gets merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@velotioaastha, will the configMap with multiple keys with your proposed configuration become multiple certificate files in the /usr/local/share/ca-certificates/
?
I didn't test it, but I wonder if simply mounting it as is will have the effect we expect: multiple cert files.
If this is the expected outcome, could you add a line explaining that CM key MUST
be something.CRT
?
We expect crt
files to be parsed by the update-ca-certificates
program used by Ubuntu to add the certs to the system ca store.
Yes, with the configuration proposed earlier, mounting a ConfigMap with multiple keys will indeed result in multiple files within the specified directory (/usr/local/share/ca-certificates/), with each key in the ConfigMap corresponding to a separate file. However, for update-ca-certificates to recognize and add these certificates to the system CA store on Ubuntu, each file name in the directory must end with .crt (as given in the description) Where do you propose I add this line? |
Thank you for your reply @velotioaastha |
659da64
to
2903099
Compare
7306fcd
to
400ecac
Compare
We have closed #254 and added the same changes here to support pull CA Certs from configmap for parquet as well |
Add support to pull the list of CA Certs from configMaps (W&B App)
Create configmap
values.yaml
configMapName: "custom-ca-certs"