Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to pull CA Certs from configMap #255

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

velotioaastha
Copy link
Contributor

Add support to pull the list of CA Certs from configMaps (W&B App)

Create configmap

apiVersion: v1
kind: ConfigMap
metadata:
  name: custom-ca-certs
data:
  ca-cert1.crt: |
    -----BEGIN CERTIFICATE-----
    ...
    -----END CERTIFICATE-----
  ca-cert2.crt: |
    -----BEGIN CERTIFICATE-----
    ...
    -----END CERTIFICATE-----

values.yaml
configMapName: "custom-ca-certs"

@velotioaastha
Copy link
Contributor Author

support for Parquet to pull ca certs from configmap can be added after this PR gets merged

Copy link
Contributor

@flamarion flamarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@velotioaastha, will the configMap with multiple keys with your proposed configuration become multiple certificate files in the /usr/local/share/ca-certificates/?
I didn't test it, but I wonder if simply mounting it as is will have the effect we expect: multiple cert files.
If this is the expected outcome, could you add a line explaining that CM key MUST be something.CRT?
We expect crt files to be parsed by the update-ca-certificates program used by Ubuntu to add the certs to the system ca store.

@velotioaastha
Copy link
Contributor Author

Yes, with the configuration proposed earlier, mounting a ConfigMap with multiple keys will indeed result in multiple files within the specified directory (/usr/local/share/ca-certificates/), with each key in the ConfigMap corresponding to a separate file. However, for update-ca-certificates to recognize and add these certificates to the system CA store on Ubuntu, each file name in the directory must end with .crt (as given in the description)

Where do you propose I add this line?

@flamarion
Copy link
Contributor

Thank you for your reply @velotioaastha
It would be great if you could add the guidance right above the configuration Here for example.
This is important to ensure customers create the crt files.

charts/operator-wandb/values.yaml Outdated Show resolved Hide resolved
charts/operator-wandb/charts/app/templates/configmap.yaml Outdated Show resolved Hide resolved
charts/operator-wandb/charts/app/templates/_deployment.tpl Outdated Show resolved Hide resolved
@velotioaastha
Copy link
Contributor Author

We have closed #254 and added the same changes here to support pull CA Certs from configmap for parquet as well
Please re-review @flamarion @danielpanzella

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to pull CA Certs from configMap
3 participants