-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support secret keys configurable #257
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think would be good to default all secrets to the previous key, like you did for Redis https://github.com/wandb/helm-charts/pull/257/files#diff-2820a1c4d6acfec8bdf8acd70e1a305cb1f536ae092834bd566632bcd86bbafdR134
Another aspect I believe is necessary, is to make this optional.
The reason is because if some customer is already using this config and the operator pull the latest version of chart, this may break because the secret key will be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As pointed out by @flamarion here we need the values for the key to default to the previous value.
hey @danielpanzella @flamarion , we've added this already, you can check this here - For mysql - |
82595aa
to
b5253ec
Compare
No description provided.