Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support secret keys configurable #257

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

amanpruthi
Copy link
Contributor

No description provided.

Copy link
Contributor

@flamarion flamarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think would be good to default all secrets to the previous key, like you did for Redis https://github.com/wandb/helm-charts/pull/257/files#diff-2820a1c4d6acfec8bdf8acd70e1a305cb1f536ae092834bd566632bcd86bbafdR134
Another aspect I believe is necessary, is to make this optional.
The reason is because if some customer is already using this config and the operator pull the latest version of chart, this may break because the secret key will be required.

Copy link
Contributor

@danielpanzella danielpanzella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed out by @flamarion here we need the values for the key to default to the previous value.

@velotioaastha
Copy link
Contributor

Another aspect I believe is necessary, is to make this optional.
The reason is because if some customer is already using this config and the operator pull the latest version of chart, this may break because the secret key will be required.

hey @danielpanzella @flamarion , we've added this already, you can check this here -

For bucket -
https://github.com/wandb/helm-charts/pull/257/files#diff-46611996f4a6fc6e0ffb1724cbd796c7fd5e7008c5c956ec1c071b38abf58d7bR21

For mysql -
https://github.com/wandb/helm-charts/pull/257/files#diff-ce26fb708141f65196c806cca1ffc3d75fc1cda8c0a7ff615d6a097ae24abcb1R19
https://github.com/wandb/helm-charts/pull/257/files#diff-ce26fb708141f65196c806cca1ffc3d75fc1cda8c0a7ff615d6a097ae24abcb1R30

For redis -
https://github.com/wandb/helm-charts/pull/257/files#diff-2820a1c4d6acfec8bdf8acd70e1a305cb1f536ae092834bd566632bcd86bbafdR134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make various secret keys configurable
4 participants