feat: Add support for topologySpreadConstraints #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velotioaastha
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
velotioaastha
changed the title
velotioaastha
changed the title
velotioaastha
force-pushed
the
aastha/add-support-for-topologyspreadconstraints
branch
from
d05cdf8 to
91f8bd6
Compare
velotioaastha
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
velotioaastha
force-pushed
the
aastha/add-support-for-topologyspreadconstraints
branch
from
91f8bd6 to
473b509
Compare
velotioaastha
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
theishshah
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
theishshah
temporarily deployed
to
Helm Charts
GitHub Actions
Inactive
theishshah
approved these changes
Dec 9, 2024
danielpanzella
requested changes
Dec 10, 2024
There was a problem hiding this comment.
redis-exporter, mysql-exporter, stackdriver, and prometheus are going to be run as single instances so not sure adding topology constraints makes any sense. I'm not sure we should be applying these to things like mysql or redis either. so probably just dont include this for any of the non-application deployments
charts/operator-wandb/charts/otel/charts/agent/templates/deamonset.yaml
Outdated
Show resolved
Hide resolved
velotioaastha
force-pushed
the
aastha/add-support-for-topologyspreadconstraints
branch
from
53c8d1f to
db5c8d6
Compare
velotioaastha
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
velotioaastha
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
velotioaastha
force-pushed
the
aastha/add-support-for-topologyspreadconstraints
branch
from
925acd3 to
10a0c21
Compare
velotioaastha
had a problem deploying
to
Helm Charts
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.