Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GCS FUSE support #283

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: GCS FUSE support #283

wants to merge 16 commits into from

Conversation

annirudh
Copy link
Contributor

No description provided.

@annirudh annirudh marked this pull request as ready for review December 17, 2024 18:47
@@ -2,7 +2,7 @@ apiVersion: v2
name: operator-wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.21.6
version: 0.21.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this should be 0.22.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, will fix.

@@ -32,6 +33,16 @@ spec:
{{- include "parquet.podLabels" . | nindent 8 }}
{{- include "parquet.labels" . | nindent 8 }}
annotations:
{{- if .Values.fuse.enabled }}
{{- if eq $bucketProvider "gcs" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this going to drop a sidecar into the pod?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it drops a sidecar. Could that cause issues?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not, just worth knowing if we see issues with pod creation in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants