-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GCS FUSE support #283
base: main
Are you sure you want to change the base?
Conversation
68f51a2
to
794e72e
Compare
b3e3189
to
e113d19
Compare
e113d19
to
2eb965c
Compare
charts/operator-wandb/Chart.yaml
Outdated
@@ -2,7 +2,7 @@ apiVersion: v2 | |||
name: operator-wandb | |||
description: A Helm chart for deploying W&B to Kubernetes | |||
type: application | |||
version: 0.21.6 | |||
version: 0.21.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically this should be 0.22.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, will fix.
@@ -32,6 +33,16 @@ spec: | |||
{{- include "parquet.podLabels" . | nindent 8 }} | |||
{{- include "parquet.labels" . | nindent 8 }} | |||
annotations: | |||
{{- if .Values.fuse.enabled }} | |||
{{- if eq $bucketProvider "gcs" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this going to drop a sidecar into the pod?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it drops a sidecar. Could that cause issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not, just worth knowing if we see issues with pod creation in the future.
e2cb8ca
to
c9d3093
Compare
No description provided.