-
Notifications
You must be signed in to change notification settings - Fork 10
chore: serve files endpoints from API pod #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new ingress path configuration was introduced in the Helm template for the operator-wandb chart. This addition conditionally creates a Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Ingress
participant API_Service
Client->>Ingress: Request to /files/*
Ingress->>API_Service: Forward to <release-name>-api:8081
API_Service-->>Ingress: Response
Ingress-->>Client: Response
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (16)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
charts/operator-wandb/templates/_ingress.tpl (1)
76-82
: Consider adding a comment explaining the purpose of the/files
endpoint.While the implementation is correct, adding a brief comment about what types of files are served by this endpoint would improve maintainability and help future developers understand the intent.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
charts/operator-wandb/templates/_ingress.tpl
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: Test Chart (v1.29.14, separate-pods)
- GitHub Check: Test Chart (v1.29.14, user-defined-secrets)
- GitHub Check: Test Chart (v1.29.14, executor-enabled)
- GitHub Check: Test Chart (v1.29.14, default)
- GitHub Check: Test Chart (v1.30.10, separate-pods)
- GitHub Check: Test Chart (v1.30.10, user-defined-secrets)
- GitHub Check: Test Chart (v1.30.10, executor-enabled)
- GitHub Check: Test Chart (v1.30.10, default)
- GitHub Check: Test Chart (v1.31.6, separate-pods)
- GitHub Check: Test Chart (v1.31.6, user-defined-secrets)
- GitHub Check: Test Chart (v1.31.6, executor-enabled)
- GitHub Check: Test Chart (v1.31.6, default)
- GitHub Check: Test Chart (v1.32.2, separate-pods)
- GitHub Check: Test Chart (v1.32.2, user-defined-secrets)
- GitHub Check: Test Chart (v1.32.2, executor-enabled)
- GitHub Check: Test Chart (v1.32.2, default)
🔇 Additional comments (1)
charts/operator-wandb/templates/_ingress.tpl (1)
76-82
: LGTM - New ingress path configuration for/files
looks good.The addition of this new path with
pathType: Prefix
correctly routes/files
traffic to the API pod, consistent with the existing/api
and/graphql
paths configuration.
closing as discussed |
Summary by CodeRabbit
/files
path to the ingress configuration, allowing users to access file-related endpoints when the global API is enabled.