fix: Enable to slow rollout of additional api ingress routes #398
Conversation
WalkthroughThis update introduces new configurable ingress paths for the API service in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Ingress Controller
participant API Service
User->>Ingress Controller: Request to /api/{path}
alt Path enabled in additionalPaths
Ingress Controller->>API Service: Forward to backend (port 8081)
else Path not enabled
Ingress Controller-->>User: Path not found/handled by other rules
end
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (16)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
charts/operator-wandb/templates/_ingress.tpl (1)
76-156: Consider documenting the purpose of each path.The implementation logic is clean, but it would be helpful to have comments that briefly describe the purpose of each API path and when users might want to enable it.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
charts/operator-wandb/Chart.yaml(1 hunks)charts/operator-wandb/templates/_ingress.tpl(1 hunks)charts/operator-wandb/values.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: Test Chart (v1.29.14, separate-pods)
- GitHub Check: Test Chart (v1.29.14, user-defined-secrets)
- GitHub Check: Test Chart (v1.29.14, executor-enabled)
- GitHub Check: Test Chart (v1.29.14, default)
- GitHub Check: Test Chart (v1.30.10, separate-pods)
- GitHub Check: Test Chart (v1.30.10, user-defined-secrets)
- GitHub Check: Test Chart (v1.30.10, executor-enabled)
- GitHub Check: Test Chart (v1.30.10, default)
- GitHub Check: Test Chart (v1.31.6, separate-pods)
- GitHub Check: Test Chart (v1.31.6, user-defined-secrets)
- GitHub Check: Test Chart (v1.31.6, executor-enabled)
- GitHub Check: Test Chart (v1.31.6, default)
- GitHub Check: Test Chart (v1.32.2, separate-pods)
- GitHub Check: Test Chart (v1.32.2, user-defined-secrets)
- GitHub Check: Test Chart (v1.32.2, executor-enabled)
- GitHub Check: Test Chart (v1.32.2, default)
🔇 Additional comments (2)
charts/operator-wandb/values.yaml (1)
209-219: Well-structured addition of configurable API paths.The new
additionalPathssection provides a clean way to selectively enable specific API routes. Setting all paths tofalseby default is a good practice that ensures a controlled rollout of these additional routes.charts/operator-wandb/Chart.yaml (1)
5-5: Appropriate version bump for the feature addition.The chart version has been correctly incremented from 0.29.0 to 0.29.1, which follows semantic versioning principles for a non-breaking feature addition.
dacbd
changed the title
ref: INFRA-888
Summary by CodeRabbit
Summary by CodeRabbit