Skip to content

fix: Update liveness/readiness/startup probes and loadbalancer healthchecks to better align with application behavior #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielpanzella wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix: Update liveness/readiness/startup probes and loadbalancer healthchecks to better align with application behavior #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
251a3f5
fix: Update liveness/readiness/startup probes and loadbalancer health…
danielpanzella Aug 29, 2025
3288063
Merge branch 'main' into danielpanzella/align-hc-to-app-behavior
danielpanzella Aug 29, 2025
00002a9
chore: Bump chart version
danielpanzella Aug 29, 2025
6e899ad
chore: Appease the linter
danielpanzella Aug 29, 2025
237ae99
chore: fix some mismatched ports
danielpanzella Aug 29, 2025
1eebb9a
chore: Update snapshots
danielpanzella Aug 29, 2025
7691509
fix: Don't create load balancer configs for services not exposed
danielpanzella Aug 29, 2025
343dbe9
fix: Azure is just built different I guess
danielpanzella Aug 29, 2025
f0d0eb3
fix: make the LB settings global, with local overrides. Add annotati…
danielpanzella Aug 29, 2025
42a9962
fix: AWS doesn't support anything more aggressive than this.
danielpanzella Aug 29, 2025
424804c
fix: Normalize readiness probes to AWS ALB minimums
danielpanzella Sep 3, 2025
a4be60a
chore: Update snaps
danielpanzella Sep 3, 2025
4d00c94
chore: Update snaps
danielpanzella Sep 3, 2025
2450646
chore: Normalize naming
danielpanzella Sep 3, 2025
95f6e24
chore: Normalize naming more
danielpanzella Sep 4, 2025
49b4c0a
Merge branch 'main' into danielpanzella/align-hc-to-app-behavior
danielpanzella Sep 4, 2025
7aed73f
chore: Fix versions after merge
danielpanzella Sep 4, 2025
e9ed95b
chore: Add ingress and service annotations for aws
danielpanzella Sep 4, 2025
be039e9
chore: More normalization
danielpanzella Sep 4, 2025
6e9ddcb
chore: Update snaps
danielpanzella Sep 4, 2025
bd1f3f1
Merge branch 'main' into danielpanzella/align-hc-to-app-behavior
danielpanzella Sep 10, 2025
65f3d22
fix: Adjust shutdown grace periods in gorilla apps to match HC and LB…
danielpanzella Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions charts/operator-wandb/Chart.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,34 @@
dependencies:
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: mysql
repository: file://charts/mysql
version: 0.1.0
Expand All @@ -52,10 +52,10 @@ dependencies:
version: 0.1.0
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: nginx
repository: file://charts/nginx
version: 0.1.0
Expand All @@ -67,27 +67,27 @@ dependencies:
version: 0.1.0
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: wandb-base
repository: file://../wandb-base
version: 0.10.2
version: 0.10.3
- name: reloader
repository: https://stakater.github.io/stakater-charts
version: 1.3.0
- name: clickhouse
repository: oci://registry-1.docker.io/bitnamicharts
version: 9.1.0
digest: sha256:84fe1a3804f2cdfdc270046e58c09d22a2ef7014e3185b0e10eb1c47f4ab391b
generated: "2025-09-04T10:21:22.432459-07:00"
digest: sha256:13b38d5332f4a9f2cb26cfad506adf4fc23a6d564182381d17dff9996132ecaa
generated: "2025-09-04T13:43:29.662814-07:00"
2 changes: 1 addition & 1 deletion charts/operator-wandb/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: operator-wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.34.14
version: 0.34.15
appVersion: 1.0.0
icon: https://wandb.ai/logo.svg

Expand Down
2 changes: 1 addition & 1 deletion charts/operator-wandb/templates/global.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
GORILLA_STATSD_HOST: "0.0.0.0"
{{- end }}
{{- end }}

GORILLA_HTTP_SHUTDOWN_GRACE_PERIOD: "15s"
GORILLA_STATSD_PORT: "8125"
# T-shirt size for deployment
GORILLA_TSHIRT_SIZE: {{ .Values.global.size | default "small" | quote }}
Expand Down
12 changes: 12 additions & 0 deletions charts/operator-wandb/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,12 @@ metadata:
"kubernetes.io/ingress.allow-http" : "false"
{{- end }}

{{- if eq .Values.global.cloudProvider "azure" }}
appgw.ingress.kubernetes.io/request-timeout: "{{ .Values.global.loadBalancer.timeoutSeconds }}"
appgw.ingress.kubernetes.io/connection-draining: "{{ .Values.global.loadBalancer.connectionDraining.enabled }}"
appgw.ingress.kubernetes.io/connection-draining-timeout: "{{ .Values.global.loadBalancer.connectionDraining.drainingTimeoutSeconds }}"
{{- end }}

{{- if .Values.ingress.annotations -}}
{{- toYaml .Values.ingress.annotations | nindent 4 }}
{{- end }}
Expand Down Expand Up @@ -111,6 +117,12 @@ metadata:
"kubernetes.io/ingress.allow-http" : "false"
{{- end }}

{{- if eq .Values.global.cloudProvider "azure" }}
appgw.ingress.kubernetes.io/request-timeout: "{{ .Values.global.loadBalancer.timeoutSeconds }}"
appgw.ingress.kubernetes.io/connection-draining: "{{ .Values.global.loadBalancer.connectionDraining.enabled }}"
appgw.ingress.kubernetes.io/connection-draining-timeout: "{{ .Values.global.loadBalancer.connectionDraining.drainingTimeoutSeconds }}"
{{- end }}

{{- if .Values.ingress.secondary.annotations -}}
{{- toYaml .Values.ingress.secondary.annotations | nindent 4 }}
{{- end }}
Expand Down
Loading
Loading