Skip to content

Conversation

@wandbjake
Copy link
Contributor

@wandbjake wandbjake commented Feb 2, 2026

This version is more ergonomic, and can be breaking since ingress is not presently used in mi.

Summary by CodeRabbit

  • Chores
    • Bumped chart version to 0.11.9
    • Updated ingress configuration for improved port handling

@wandbjake wandbjake requested a review from a team as a code owner February 2, 2026 19:02
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Warning

Rate limit exceeded

@wandbjake has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

The PR updates the Helm chart version from 0.11.8 to 0.11.9 and modifies the Ingress resource backend configuration to reference the service port by name rather than by numeric value.

Changes

Cohort / File(s) Summary
Helm Chart Version
charts/wandb-base/Chart.yaml
Chart version bumped from 0.11.8 to 0.11.9.
Ingress Template Configuration
charts/wandb-base/templates/ingress.yaml
Backend service port reference changed from numeric port value to named port reference (number to name).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • danielpanzella
  • dacbd
  • theishshah

Poem

A hop from point-eight to point-nine we take, 🐰
Port names now clear for clarity's sake,
The ingress charts organized with grace,
Infrastructure code in its proper place! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and accurately summarizes the main change: moving ingress port specification from service level to path level.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jake/ingress-prot

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@charts/wandb-base/templates/ingress.yaml`:
- Around line 58-59: The template currently unconditionally writes port.name
using the value at .paths[].port which breaks when that value is numeric; change
the ingress backend rendering to detect whether .paths[].port is a number or a
string and emit port.number for numeric ports and port.name for named ports
(i.e. check .paths[].port and conditionally render port.number vs port.name so
both numeric and named ports are supported and backward-compatible).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants