-
Notifications
You must be signed in to change notification settings - Fork 13
specify ingress path port on path instead of on service #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe PR updates the Helm chart version from 0.11.8 to 0.11.9 and modifies the Ingress resource backend configuration to reference the service port by name rather than by numeric value. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@charts/wandb-base/templates/ingress.yaml`:
- Around line 58-59: The template currently unconditionally writes port.name
using the value at .paths[].port which breaks when that value is numeric; change
the ingress backend rendering to detect whether .paths[].port is a number or a
string and emit port.number for numeric ports and port.name for named ports
(i.e. check .paths[].port and conditionally render port.number vs port.name so
both numeric and named ports are supported and backward-compatible).
This version is more ergonomic, and can be breaking since ingress is not presently used in mi.
Summary by CodeRabbit