Skip to content

specify ingress path port on path instead of on service #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wandbjake wants to merge 3 commits into
base: main
Choose a base branch
from
Open

specify ingress path port on path instead of on service #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ae59db
specify ingress path port on path instead of on service
wandbjake Feb 2, 2026
d716e17
support both
wandbjake Feb 2, 2026
f7b5429
update snapshots
wandbjake Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/wandb-base/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: wandb-base
description: A generic helm chart for deploying services to kubernetes
type: application
version: 0.11.8
version: 0.11.9
icon: https://wandb.ai/logo.svg

maintainers:
Expand Down
6 changes: 5 additions & 1 deletion charts/wandb-base/templates/ingress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ spec:
service:
name: {{ include "wandb-base.fullname" $ }}
port:
number: {{ $.Values.service.port }}
{{- if kindIs "string" .port }}
name: {{ .port }}
{{- else }}
number: {{ .port }}
{{- end }}
{{- end }}
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion test-configs/wandb-base/__snapshots__/global-volumeMounts-override.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: wandb-base-0.11.8
helm.sh/chart: wandb-base-0.11.9
app.kubernetes.io/name: wandb-base
app.kubernetes.io/instance: chartsnap
app.kubernetes.io/managed-by: Helm
Expand Down
2 changes: 1 addition & 1 deletion test-configs/wandb-base/__snapshots__/global-volumes-and-mounts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: wandb-base-0.11.8
helm.sh/chart: wandb-base-0.11.9
app.kubernetes.io/name: wandb-base
app.kubernetes.io/instance: chartsnap
app.kubernetes.io/managed-by: Helm
Expand Down
2 changes: 1 addition & 1 deletion test-configs/wandb-base/__snapshots__/global-volumes-override.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: wandb-base-0.11.8
helm.sh/chart: wandb-base-0.11.9
app.kubernetes.io/name: wandb-base
app.kubernetes.io/instance: chartsnap
app.kubernetes.io/managed-by: Helm
Expand Down
2 changes: 1 addition & 1 deletion test-configs/wandb-base/__snapshots__/global-volumes.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: wandb-base-0.11.8
helm.sh/chart: wandb-base-0.11.9
app.kubernetes.io/name: wandb-base
app.kubernetes.io/instance: chartsnap
app.kubernetes.io/managed-by: Helm
Expand Down
4 changes: 2 additions & 2 deletions test-configs/wandb-base/__snapshots__/ingress-gcp.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ spec:
template:
metadata:
labels:
helm.sh/chart: wandb-base-0.11.8
helm.sh/chart: wandb-base-0.11.9
app.kubernetes.io/name: wandb-base
app.kubernetes.io/instance: chartsnap
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -113,7 +113,7 @@ spec:
service:
name: chartsnap-wandb-base
port:
number:
name: http
---
# Source: wandb-base/templates/ingress.yaml
apiVersion: networking.gke.io/v1beta1
Expand Down
1 change: 1 addition & 0 deletions test-configs/wandb-base/ingress-gcp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ ingress:
paths:
- path: /
pathType: ImplementationSpecific
port: http
Loading