Skip to content

fix(testing): Add Variable expansion testing #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zacharyblasczyk wants to merge 9 commits into
base: main
Choose a base branch
from
Open

fix(testing): Add Variable expansion testing #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b979574
fix(testing): Add Variable expansion testing
zacharyblasczyk Feb 3, 2026
a9feb0f
Add dynamic environment expansion test generator
zacharyblasczyk Feb 3, 2026
bc020e6
fix lint
zacharyblasczyk Feb 3, 2026
97659c5
switch to go based program
zacharyblasczyk Feb 3, 2026
849fe94
picking tag busybox:stable-musl for image reusability
zacharyblasczyk Feb 3, 2026
c4355f6
revert
zacharyblasczyk Feb 3, 2026
77e5600
revert
zacharyblasczyk Feb 3, 2026
6f9d03b
fix the docker image 429
zacharyblasczyk Feb 3, 2026
02007d6
updates per coderabbitai
zacharyblasczyk Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/operator-wandb/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: operator-wandb
description: A Helm chart for deploying W&B to Kubernetes
type: application
version: 0.40.0
version: 0.40.1
appVersion: 1.0.0
icon: https://wandb.ai/logo.svg

Expand Down
6 changes: 1 addition & 5 deletions charts/operator-wandb/templates/_env.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ Global values will override any chart-specific values.
value: {{ include "wandb.mysql" . | trim | quote }}
{{- end -}}

{{- define "wandb.clickhouseConfigEnvs" -}}
{{- define "wandb.clickhouseEnvs" -}}
{{- /*
ATTENTION!
Expand Down Expand Up @@ -300,10 +300,6 @@ Global values will override any chart-specific values.
{{- end -}}
{{- end -}}

{{- define "wandb.clickhouseEnvs" -}}
{{ include "wandb.clickhouseConfigEnvs" . }}
{{- end -}}

{{- define "wandb.historyStoreEnvs" -}}
- name: GORILLA_HISTORY_STORE
value: {{ include "wandb.historyStore" . | quote }}
Expand Down
2 changes: 1 addition & 1 deletion charts/operator-wandb/templates/glue.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ data:

# ClickHouse configuration using existing clickhouse variables
{{- if .Values.global.clickhouse.host }}
GORILLA_GLUE_CLICKHOUSE_ADDRESS: "http://$(WF_CLICKHOUSE_HOST):$(WF_CLICKHOUSE_PORT)"
GORILLA_GLUE_CLICKHOUSE_ADDRESS: "http://{{ include "wandb.clickhouse.host" . | trim }}:{{ include "wandb.clickhouse.port" . | trim }}"
{{- end }}

# Activity store configuration
Expand Down
Loading
Loading