-
Notifications
You must be signed in to change notification settings - Fork 145
feat(weave): store call views in CallViewSpec objects #6010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(weave): store call views in CallViewSpec objects #6010
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
27a2909 to
2fd6678
Compare
b40dd8b to
8586291
Compare
2fd6678 to
1ce2762
Compare
8586291 to
474006b
Compare
1ce2762 to
4e4ebb6
Compare
474006b to
0c6991c
Compare
e5ce748 to
f4d4fb4
Compare
0c6991c to
bf139a9
Compare
Changes view storage from summary.weave.views blob to a dedicated CallViewSpec object referenced by view_spec_ref. This enables content-addressed deduplication of identical view configurations across calls. Changes: - Add CallViewSpec builtin object class with typed view item schemas - Register CallViewSpec in builtin_object_registry - Add _pending_views field to Call for collecting views during execution - Update set_call_view to store in _pending_views instead of summary - Add build_and_save_call_view_spec to create and save CallViewSpec at call_end - Update weave_client to call build_and_save_call_view_spec and set view_spec_ref - Update tests to verify new storage format
bf139a9 to
0aa64fe
Compare
f4d4fb4 to
204c277
Compare
|
❌ Documentation Reference Check Failed No documentation reference found in the PR description. Please add either:
This check is required for all PRs that start with "feat(weave)" unless they explicitly state "docs are not required". Please update your PR description and this check will run again automatically. |
|
Consolidated into #6019 |

Summary
Changes view storage from
summary.weave.viewsblob to a dedicatedCallViewSpecobject referenced byview_spec_ref. This enables content-addressed deduplication of identical view configurations across calls.Changes
CallViewSpecbuiltin object class with typed view item schemas:ContentViewItem: base64-encoded content with mimetypeTableRefViewItem: reference to a Table objectObjectRefViewItem: reference to a SavedView or other objectScoreSummaryWidgetItem,ChildPredictionsWidgetItem: widget markersCallViewSpecinbuiltin_object_registry_pending_viewsfield toCallfor collecting views during executionset_call_viewto store in_pending_viewsinstead of summarybuild_and_save_call_view_specto create and saveCallViewSpecat call_endweave_clientto callbuild_and_save_call_view_specand setview_spec_ref