Skip to content

Conversation

@bcsherma
Copy link
Member

@bcsherma bcsherma commented Jan 29, 2026

Summary

Changes view storage from summary.weave.views blob to a dedicated CallViewSpec object referenced by view_spec_ref. This enables content-addressed deduplication of identical view configurations across calls.

Changes

  • Add CallViewSpec builtin object class with typed view item schemas:
    • ContentViewItem: base64-encoded content with mimetype
    • TableRefViewItem: reference to a Table object
    • ObjectRefViewItem: reference to a SavedView or other object
    • ScoreSummaryWidgetItem, ChildPredictionsWidgetItem: widget markers
  • Register CallViewSpec in builtin_object_registry
  • Add _pending_views field to Call for collecting views during execution
  • Update set_call_view to store in _pending_views instead of summary
  • Add build_and_save_call_view_spec to create and save CallViewSpec at call_end
  • Update weave_client to call build_and_save_call_view_spec and set view_spec_ref
  • Update tests to verify new storage format

Copy link
Member Author

bcsherma commented Jan 29, 2026

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 77.27273% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
weave/trace/view_utils.py 60.52% 8 Missing and 7 partials ⚠️

📢 Thoughts on this report? Let us know!

@bcsherma bcsherma force-pushed the feat/widget-types-extended-set-view branch from 27a2909 to 2fd6678 Compare January 29, 2026 01:20
@bcsherma bcsherma force-pushed the feat/callviewspec-storage branch 2 times, most recently from b40dd8b to 8586291 Compare January 29, 2026 01:43
@bcsherma bcsherma force-pushed the feat/widget-types-extended-set-view branch from 2fd6678 to 1ce2762 Compare January 29, 2026 01:43
@bcsherma bcsherma force-pushed the feat/callviewspec-storage branch from 8586291 to 474006b Compare January 29, 2026 01:46
@bcsherma bcsherma force-pushed the feat/widget-types-extended-set-view branch from 1ce2762 to 4e4ebb6 Compare January 29, 2026 01:46
@bcsherma bcsherma force-pushed the feat/callviewspec-storage branch from 474006b to 0c6991c Compare January 29, 2026 02:30
@bcsherma bcsherma force-pushed the feat/widget-types-extended-set-view branch 2 times, most recently from e5ce748 to f4d4fb4 Compare January 29, 2026 03:35
@bcsherma bcsherma force-pushed the feat/callviewspec-storage branch from 0c6991c to bf139a9 Compare January 29, 2026 03:35
Changes view storage from summary.weave.views blob to a dedicated CallViewSpec
object referenced by view_spec_ref. This enables content-addressed deduplication
of identical view configurations across calls.

Changes:
- Add CallViewSpec builtin object class with typed view item schemas
- Register CallViewSpec in builtin_object_registry
- Add _pending_views field to Call for collecting views during execution
- Update set_call_view to store in _pending_views instead of summary
- Add build_and_save_call_view_spec to create and save CallViewSpec at call_end
- Update weave_client to call build_and_save_call_view_spec and set view_spec_ref
- Update tests to verify new storage format
@bcsherma bcsherma force-pushed the feat/callviewspec-storage branch from bf139a9 to 0aa64fe Compare January 29, 2026 03:49
@bcsherma bcsherma force-pushed the feat/widget-types-extended-set-view branch from f4d4fb4 to 204c277 Compare January 29, 2026 03:49
@github-actions
Copy link
Contributor

❌ Documentation Reference Check Failed

No documentation reference found in the PR description. Please add either:

This check is required for all PRs that start with "feat(weave)" unless they explicitly state "docs are not required". Please update your PR description and this check will run again automatically.

@bcsherma
Copy link
Member Author

Consolidated into #6019

@bcsherma bcsherma closed this Jan 30, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants