Skip to content

Fix flush #6026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
tssweeney wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix flush #6026

tssweeney wants to merge 1 commit into from

Conversation

@tssweeney
Copy link
Collaborator

@tssweeney tssweeney commented Jan 30, 2026 •
edited
Loading

This PR fixes 2 bugs in a single change. First, the bugs:

  1. Calls written with call_end have long-delayed monitors
  2. We have unidentified memory leak (for which this is def some portion).

Some context:

  1. In 91fd3ff, we introduced a new flag on call_end (flush_immediately), defaulting to False.
  2. This changed existing behavior, meaning that the client would queue up calls to be flushed, but not flush until some later call to flush (only happens with a call batch).
  3. As a result, call_end would result in delayed monitors and buildup of data

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wandbot-3000
Copy link

wandbot-3000 bot commented Jan 30, 2026

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=ceda097e0008f51b1c46e44c401a2be36addd4be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tssweeney