Skip to content

core: huge dependencies update #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

core: huge dependencies update #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions e2e/cypress/e2e/left.panel.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ describe('left panel', () => {
const length: number = favoritesState.shortcuts.length
cy.get('.favoritesPanel').contains('Shortcuts').should('be.visible')

cy.get('@shortcuts').find('.bp4-tree-node-content-1').its('length').should('equal', length)
cy.get('@shortcuts').find('.bp5-tree-node-content-1').its('length').should('equal', length)

SHORTCUTS.forEach((shortcut) => {
cy.get('@shortcuts').contains(shortcut).should('be.visible')
Expand All @@ -89,7 +89,7 @@ describe('left panel', () => {
// const length: number = favoritesState.places.length
// cy.get('.favoritesPanel').contains('Places').should('be.visible')

// cy.get('@places').find('.bp4-tree-node-content-1').its('length').should('equal', length)
// cy.get('@places').find('.bp5-tree-node-content-1').its('length').should('equal', length)

// favoritesState.places.forEach((place: any) => {
// cy.get('@places').contains(place.label).should('be.visible')
Expand All @@ -112,7 +112,7 @@ describe('left panel', () => {
// // wait 5 secs: this is the delay we wait before updating drive list
// cy.wait(5000)

// cy.get('@places').find('.bp4-tree-node-content-1').its('length').should('equal', favoritesState.places.length)
// cy.get('@places').find('.bp5-tree-node-content-1').its('length').should('equal', favoritesState.places.length)

// favoritesState.places.forEach((place: any) => {
// cy.get('@places').contains(place.label).should('be.visible')
Expand All @@ -123,7 +123,7 @@ describe('left panel', () => {
const path = favoritesState.shortcuts[1].path
const label = SHORTCUTS[1]

cy.get('.favoritesPanel > ul > li:eq(0) .bp4-tree-node-content-1').contains(label).click()
cy.get('.favoritesPanel > ul > li:eq(0) .bp5-tree-node-content-1').contains(label).click()

cy.get('@stub_cd0').should('be.calledWith', path)
})
Expand Down
2 changes: 1 addition & 1 deletion e2e/cypress/e2e/tablist.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ describe('tablist', () => {
})

it('right-click on the tab should show the tab menu', () => {
cy.get('#view_0 .tablist').contains('/').find('.bp4-button-text').rightclick('right')
cy.get('#view_0 .tablist').contains('/').find('.bp5-button-text').rightclick('right')

cy.get('@stub_invoke')
.should('be.called')
Expand Down
2 changes: 1 addition & 1 deletion e2e/cypress/e2e/toolbar.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ describe('toolbar', () => {
it('should show an alert then focus input when typing a non valid path', () => {
cy.get('#view_0 [data-cy-path]').type(':{enter}')

cy.get('.data-cy-alert').should('be.visible').find('.bp4-button').click()
cy.get('.data-cy-alert').should('be.visible').find('.bp5-button').click()

cy.get('#view_0 [data-cy-path]').should('have.value', ':')

Expand Down
Loading
Loading