This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
ci(httpserver): cross compile httpserver #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <[email protected]> removed cross.toml Signed-off-by: Brooks Townsend <[email protected]> working directory Signed-off-by: Brooks Townsend <[email protected]> windows artifact Signed-off-by: Brooks Townsend <[email protected]> dumb Signed-off-by: Brooks Townsend <[email protected]> dumb2 Signed-off-by: Brooks Townsend <[email protected]> ASSEMBLE Signed-off-by: Brooks Townsend <[email protected]> cleanup for PR Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
ci/cross-compile-httpserver
branch
from
1bcf281
to
ba841b6
Compare
.github/workflows/httpserver.yml
Outdated
|
|
||
| - name: Determine artifact name | ||
| - name: Install latest Rust stable toolchain |
There was a problem hiding this comment.
Looks like this step is duplicated?
Signed-off-by: Brooks Townsend <[email protected]> no duplicate Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
ci/cross-compile-httpserver
branch
from
ba841b6
to
6164c64
Compare
connorsmith256
approved these changes
Aug 8, 2023
|
No worries, and thanks for shout out. That was based on work that @thomastaylor312 had shared that I used to do that, so thanks Taylor lol. |
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
After our last round of releases we noticed that we were getting linking errors on some capability providers, but not others, with dependency graphs that matched the exact same releases that failed. We assumed this was because of our use of cross, which has caused us problems in the past. This PR is the first of many that actually sets us up to cross compile these releases.
This structure of cross compiling and the code came from wasmCloud/wadm#82, huge thanks to @stephenandary for getting this done in a way that worked great for providers too.
You can see a successful run of this action, and download the
provider-archivefor yourself here: https://github.com/wasmCloud/capability-providers/actions/runs/5801109768Related Issues
HTTPClient PR, which did fail to release #261
Release Information
HTTPserver v0.19.1 (I would like to release this so we can test that all functionality works)
Consumer Impact
I'm removing the
armv7Linux target from the provider archive because we do not have a host runtime that runs on that target yet.Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification
I manually ensured that the httpserver here worked on aarch64-darwin. I want to test this with Linux as well once it releases and I don't have to start from file only.