Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes dependence on instance ID for all monitoring logic #26

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

autodidaddict
Copy link
Member

Since instance ID will always be "n/a" on the new 0.60 heartbeats, this removes reliance on instance IDs for building the observed model.

@autodidaddict
Copy link
Member Author

Testing methodology:

  • Updated unit tests to reflect the no-longer-unique nature of the instance ID
  • Started a lattice observer against the default lattice
  • Started two hosts on the lattice
  • Added, removed providers and actors and watched the observer properly reflect the lattice state

@autodidaddict autodidaddict marked this pull request as ready for review February 1, 2023 13:56
@autodidaddict
Copy link
Member Author

Addresses #25

@connorsmith256 connorsmith256 merged commit c4c0860 into main Feb 2, 2023
@connorsmith256 connorsmith256 deleted the fix/iid_dedupe branch February 2, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants