feat(*)!: support new authoritative heartbeat shape #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
changed the title
brooksmtownsend
force-pushed
the
feat/actor_scaled
branch
from
57b7aab
to
1899d31
Compare
brooksmtownsend
force-pushed
the
feat/new-shape-of-heartbeat
branch
from
2ae2f62
to
1076bfa
Compare
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/new-shape-of-heartbeat
branch
from
1076bfa
to
d5c00b0
Compare
connorsmith256
approved these changes
Jan 24, 2024
|
|
||
| test "Propertly records LEGACY host heartbeat" do | ||
| hb = CloudEvents.host_heartbeat_old(@test_host, %{foo: "bar", baz: "biz"}) | ||
| test "Propertly records NEW host heartbeat" do |
There was a problem hiding this comment.
Good thing it's propertly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR adds support for the heartbeat shape in wasmCloud v0.82, which includes a bit more information. You'll notice this is returning to a similar heartbeat to what we called "previous" or "legacy". This is because the older heartbeat still tracked individual instances, so scaling to ~10000 instances or so would exceed the NATS message payload for the heartbeat. The new heartbeat v2 final, as supported in this PR, tracks instance scale with a single
u32.Related Issues
Based off of #36 and should be reviewed independently
wasmCloud/wasmCloud#1160
Release Information
v0.5.0
Consumer Impact
Testing
Unit Test(s)
Modified "old" "legacy" tests to support new heartbeat shape
Acceptance or Integration
Manual Verification