Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation Builder #5071

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Annotation Builder #5071

wants to merge 3 commits into from

Conversation

maminrayej
Copy link
Contributor

Resolves #5069.

@maminrayej maminrayej mentioned this pull request Sep 6, 2024
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still storing things as a toml in memory, which is not ideal and doesn't cause the issue with PartialEq being solved. It also attaches things as always stored in toml, but we may want in the future to target other formats.

Ideally, we should have something like:

#[derive(Debug, Clone, Default)]
pub struct CommandAnnotationBuilder {
    annotations: HashMap<String, Box<dyn Serializable>>,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make creating annotations for a command easier
2 participants