Fix module instantiation bug: out of bounds memory access
#1531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following Wasm input was successfully instantiated in Wasmi whereas it should have failed with:
The bug was that Wasmi was lossily converting a
u64
value into au32
and thus read the(i64.const -1095216660480)
offset value as0
instead of a huge number. This is probably an artifact from the times where Wasmi did not yet supportmemory64
. I wonder why the fuzzing system didn't catch this (earlier).Thanks @alexcrichton for the report.