Skip to content

Move FuncTranslator internals into func submodule of translator module #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jun 5, 2025

These changes make it simpler for #1512 to build an alternative FuncTranslator.

No logic is modified in this PR, only code is moved around. That's why the diff is so big.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.76%. Comparing base (2254f91) to head (b6e14c5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/translator/utils.rs 0.00% 3 Missing ⚠️
crates/wasmi/src/engine/translator/func/utils.rs 95.83% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1532      +/-   ##
==========================================
+ Coverage   71.75%   71.76%   +0.01%     
==========================================
  Files         177      179       +2     
  Lines       16524    16524              
==========================================
+ Hits        11857    11859       +2     
+ Misses       4667     4665       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop merged commit 57b28e7 into main Jun 5, 2025
19 checks passed
@Robbepop Robbepop deleted the rf-restructure-translator-module branch June 5, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant