Improve error message when user specifies an invalid template #2992
Conversation
| throwInvalidTemplateNameUsedError :: Command a | ||
| throwInvalidTemplateNameUsedError = | ||
| throwProjectCreationError $ | ||
| "Are you sure that the template exists?" | ||
| <> " 🤔 Check the list of templates here: https://github.com/wasp-lang/starters" |
There was a problem hiding this comment.
Moved this out of common into a local function:
- It's very specific and only used in a single place.
- The function was missing information to output a meaningful error message (chosen template name, available templates). Both things are available in the caller.
| findTemplateOrThrow templateName = case findTemplateByString availableTemplates templateName of | ||
| Just x -> return x | ||
| Nothing -> throwProjectCreationError $ makeInvalidTemplateNameError templateName |
There was a problem hiding this comment.
I didn't use maybe on purpose, I find this more readable.
I can use maybe if anyone objects :)
| findTemplateByString availableTemplates templateName | ||
| & maybe throwInvalidTemplateNameUsedError return | ||
| findTemplateOrThrow templateName = case findTemplateByString availableTemplates templateName of | ||
| Just x -> return x |
There was a problem hiding this comment.
Maybe swap x with starterTemplate?
There was a problem hiding this comment.
I've made some extra changes. We now always list all the templates explicitly but never point to the repository with the templates.
I think this is an improvement because users know what they have to input without leaving the terminal.
The downside is that it's not as easy to explore the templates before creating a project with one, but I don't think this is important (especially because the old link pointed only to the starters repo, without mentioning OpenSaas.
Fixes #2960