-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Use Wasp compiler version for libs #3501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: templates-to-libs
Are you sure you want to change the base?
Conversation
Deploying wasp-docs-on-main with
|
| Latest commit: |
00b6ea8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://59930995.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://template-to-libs-no-hashes.wasp-docs-on-main.pages.dev |
| lib_name=$(grep '"name"' package.json | cut -d'"' -f4) | ||
| lib_version=$(grep '"version"' package.json | cut -d'"' -f4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not using jq since not all of our CI workflows have it.
| wasp-cli) | ||
| echo_and_eval "$RUN_CMD" | ||
| ;; | ||
| libs:bust-cache) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "enabler" command, we have a special command we run after each lib build to bust the cache.
@wasp.sh/wasp-cli
@wasp.sh/wasp-cli-darwin-arm64-unknown
@wasp.sh/wasp-cli-darwin-x64-unknown
@wasp.sh/wasp-cli-linux-x64-glibc
@wasp.sh/wasp-cli-linux-x64-musl
commit: |
Description
Use Wasp compiler version as the lib version. This is great for shipping the libs to our users - the libs are of the same version as the compiler.
This is a bit annoying for us when developing the libs since we need manually bust the
npmcache for the libs to test the updated libs code. That's why we implement the./run libs:bust-cachecommand.Related to #2936
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.