Remove leftover jest-dom types from the SDK.
#3522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranjoMindek
temporarily deployed
to
fly-deploy-test
GitHub Actions
Inactive
@wasp.sh/wasp-cli
@wasp.sh/wasp-cli-darwin-arm64-unknown
@wasp.sh/wasp-cli-darwin-x64-unknown
@wasp.sh/wasp-cli-linux-x64-glibc
@wasp.sh/wasp-cli-linux-x64-musl
commit: |
cprecioso
requested changes
Dec 19, 2025
cprecioso
approved these changes
Dec 19, 2025
Member
cprecioso
left a comment
cprecioso
left a comment
There was a problem hiding this comment.
LGTM and makes sense to me. I see CI passes so feels fine. Good job.
I understand a changelog entry is not required since this is not a user-facing change, right? However, if it's solving any issue or bug it'd be nice to have it there.
Contributor
Author
|
It's not solving anything user facing, we just had extra stuff in SDK we didn't really need. That's why I'm keeping it undocumented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've removed
jest-domtypes from the SDKtsconfigbecause we no longer require it since movingjest-domtypes tovite-end.d.tsfile: https://github.com/wasp-lang/wasp/pull/2656/filesFull tested table:
vite -
import '@testing-library/jest-dom'present insrc/vite-env.d.ts.sdk -
testing-library/jest-dompresent insdk/wasp/tsconfig.json'stypesfield.user -
node_modules/@testing-librarypresent in./tsconfig.json'stypeRootsfield of user's tsconfig.compiles -
wasp compileIDE - editor support, no "red squiggly lines"
Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.