Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update enforce approve rule #321

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Update enforce approve rule #321

merged 3 commits into from
Nov 11, 2024

Conversation

zangjiucheng
Copy link
Member

@zangjiucheng zangjiucheng commented Nov 9, 2024 •
edited by BluCodeGH
Loading

Update the Enforce Rule with following:

  1. PR should be approve by people in omnibus-reviewers (active member) and in default-reviewers (project-lead) (Suggest by Jason, ensure the quality of code)
  2. If the author of PR is in the default-team, then it should default bypass the default-reviewers team check.

This change is Reviewable

@zangjiucheng zangjiucheng requested review from a team as code owners November 9, 2024 23:13
@zangjiucheng zangjiucheng merged commit 2dad6a0 into master Nov 11, 2024
1 check passed
@zangjiucheng zangjiucheng deleted the j7zang/enforce-rule-updated branch November 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zangjiucheng