Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated config.py rate and read_bulk to make data more smooth #326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AshTheEngiqueer
Copy link

@AshTheEngiqueer AshTheEngiqueer commented Nov 11, 2024

Description

Changed RATE and READ_BULK in sources\ni\configuration.py to 20,000 and 2,000 respectively to reduce sensor noise on Flintec load cell

Developer Testing

Tested new constants with DAQ NI box and saw noise reduced (previously +-200g on flintec load cell, now +- 10g)

Reviewer Testing

Here's what you should do to quickly validate my changes:

Run dashboard with DAQ sensors and observe noise, compare to old NI config


This change is Reviewable

@AshTheEngiqueer AshTheEngiqueer requested review from a team as code owners November 11, 2024 22:36
Copy link
Member

@zangjiucheng zangjiucheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, (Just unblock the enforce git action check, not review the code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants