Skip to content

Conversation

zangjiucheng
Copy link
Member

@zangjiucheng zangjiucheng commented Jul 9, 2025

Description

  • PySide6 can not equal to 6.9.1 due to pyqtgraph require, Relative Bug Report
  • Update the setup script to check the python version

This PR closes #401.

Action Require

  • Update DAQ Server to 3.13 Python Interpreter.

Reviewer Testing

Here's what you should do to quickly validate my changes:

  • Play around with any feature you need in the omnibus to check everything is still working.

This change is Reviewable

Summary by CodeRabbit

Summary by CodeRabbit

  • Documentation

    • Updated documentation to specify Python 3.13 as the required version.
  • Chores

    • Added Python 3.13 version checks to setup scripts to prevent installation with incompatible Python versions.
    • Modified package requirements to exclude a problematic PySide6 version, with added explanatory comments.
    • Updated CI workflow to use Python 3.13 for testing.

@zangjiucheng zangjiucheng requested review from a team as code owners July 9, 2025 18:02
Copy link
Contributor

coderabbitai bot commented Jul 9, 2025

Walkthrough

The changes update the project's Python version requirement from 3.11 to 3.13 in documentation and setup scripts. They add Python 3.13 version checks to both setup scripts and adjust the PySide6 dependency constraint in the dashboard requirements to exclude a problematic version, with explanatory comments.

Changes

Cohort / File(s) Change Summary
Documentation README.md
- Updated Python version requirement from 3.11 to 3.13 in documentation.
Setup Scripts setup.bat
setup.sh
- Added logic to check for Python 3.13.x before proceeding with setup; exits with error if not found.
Dashboard Dependencies sinks/dashboard/requirements.txt
- Changed PySide6 constraint to exclude version 6.9.1; added comments explaining the exclusion.
CI Workflow .github/workflows/test.yml
- Updated GitHub Actions workflow to use Python 3.13 instead of 3.11.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SetupScript
    participant PythonInterpreter

    User->>SetupScript: Run setup.bat or setup.sh
    SetupScript->>PythonInterpreter: Query Python version
    PythonInterpreter-->>SetupScript: Return version info
    SetupScript->>SetupScript: Check if version == 3.13.x
    alt Version is 3.13.x
        SetupScript->>SetupScript: Continue setup process
    else Version is not 3.13.x
        SetupScript->>User: Display error and exit
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective Addressed Explanation
Upgrade system to officially support Python 3.13 (#401)
Ensure all functions are tested on Python 3.13 (#401) No explicit test code changes shown; verification unclear.
Update setup scripts to enforce Python 3.13 (#401)
Update CI workflows to use Python 3.13 (#401)

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes detected.

Poem

A hop and a skip, we leap to Thirteen,
Python's new cloak, crisp and clean!
Scripts now check, with a whisker twitch,
For the right version—no room for glitch.
Dashboard dependencies, carefully pruned,
Omnibus is ready, fully attuned!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3042761 and cef90c3.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch j7zang/omnibus-3.13

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zangjiucheng
Copy link
Member Author

Test with all the sinks, seems to be working well.

Wait for Production Test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] - Omnibus 3.13 Official Support
1 participant