-
Notifications
You must be signed in to change notification settings - Fork 71
BSM2 Translator Block Re-Scaling #1546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Noting that the ScalingProfiler cannot currently be applied to the ASM1/ADM1 translator block as well as the ASM2d/ADM1 translator block. ASM1/ADM1: Profiler does not support Expr_ifs While the ScalingProfiler does work with the other two translator blocks in this PR, it may just make more sense to ignore these translator tests altogether since the output is seemingly not very useful anyway
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small summary, condition numbers for adm1-asm1 traslater is 3.9e5; for adm1-asm2d is 4.5e5; for asm1-adm1 is 2.7e6; for asm2d-adm1 is only 34. A surprise it is the lowest for asm2d-adm1 flowsheet, which indicates might be easiest to solve with the specific conditions in the test file.
Summary/Motivation:
Adds the new IDAES scaling routine (scaler objects) to the BSM2 translator blocks
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: