Add Electrocoagulation 0D Model #1573
Conversation
| ) | ||
|
|
||
| @self.Constraint(doc="Overpotential calculation") | ||
| def eq_nernst_overpotential(b): |
There was a problem hiding this comment.
Just double checking how you got this. Could you reference the equation number from the source?
There was a problem hiding this comment.
added some equation numbers as they appear in the references
| def conductivity(b): | ||
| return pyunits.convert( | ||
| prop_in.conc_mass_phase_comp["Liq", "TDS"] / b.tds_to_cond_conversion, | ||
| to_units=pyunits.S / pyunits.m, | ||
| ) |
There was a problem hiding this comment.
Do you think we should eventually add this (or similar) to MCAS?
There was a problem hiding this comment.
Yep. If I was an experimentalist with a cond > TDS parameter that I knew worked for my system, I would want to have this option.
|
RTD check failing possibly because of missing/misplaced comma: |
|
@luohezhiming I thought it might be good for you to review this as it might relate to your work on electroN-P |
|
@lbianchi-lbl FYI I added myself and @MuktaHardikar as CODEOWNERS for the model in this PR. Should we be doing that or let you primo devs handle that sort of thing? |
|
@MuktaHardikar will take a look. |
Fixes/Resolves:
Adds EC 0D model, costing, test file, and documentation.
Summary/Motivation:
This PR adds a 0D electrocoagulation model compatible with MCAS that builds off of the existing EC ZO model. In particular, this model adds the ability to estimate the overpotential required with Nernst and Tafel equations.
The model has been validated against results in both the Gu (2009) paper and the Dubrawski (2014) paper. These are provided as test cases in addition to a costing test case developed as part of the SETO project in collaboration with NMSU.
TODO:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: