Development of ASM3 Model #1593
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luohezhiming
requested review from
MarcusHolly,
adam-a-a,
agarciadiego and
Morgan88888888
as code owners
adam-a-a
reviewed
Jun 16, 2025
Comment on lines
+506
to
+578
| # def _TSS(self): | ||
| # tss = ( | ||
| # self.conc_mass_comp["X_S"] | ||
| # + self.conc_mass_comp["X_I"] | ||
| # + self.conc_mass_comp["X_BH"] | ||
| # + self.conc_mass_comp["X_BA"] | ||
| # + self.conc_mass_comp["X_P"] | ||
| # ) | ||
| # return self.params.COD_to_SS * tss | ||
| # | ||
| # self.TSS = pyo.Expression( | ||
| # rule=_TSS, | ||
| # doc="Total suspended solids (TSS)", | ||
| # ) | ||
| # | ||
| # def _BOD5(self, i): | ||
| # bod5 = ( | ||
| # self.conc_mass_comp["S_S"] | ||
| # + self.conc_mass_comp["X_S"] | ||
| # + (1 - self.params.f_p) | ||
| # * (self.conc_mass_comp["X_BH"] + self.conc_mass_comp["X_BA"]) | ||
| # ) | ||
| # # TODO: 0.25 should be a parameter instead as it changes by influent/effluent | ||
| # return self.params.BOD5_factor[i] * bod5 | ||
| # | ||
| # self.BOD5 = pyo.Expression( | ||
| # ["raw", "effluent"], | ||
| # rule=_BOD5, | ||
| # doc="Five-day Biological Oxygen Demand (BOD5)", | ||
| # ) | ||
| # | ||
| # def _COD(self): | ||
| # cod = ( | ||
| # self.conc_mass_comp["S_S"] | ||
| # + self.conc_mass_comp["S_I"] | ||
| # + self.conc_mass_comp["X_S"] | ||
| # + self.conc_mass_comp["X_I"] | ||
| # + self.conc_mass_comp["X_BH"] | ||
| # + self.conc_mass_comp["X_BA"] | ||
| # + self.conc_mass_comp["X_P"] | ||
| # ) | ||
| # return cod | ||
| # | ||
| # self.COD = pyo.Expression( | ||
| # rule=_COD, | ||
| # doc="Chemical Oxygen Demand", | ||
| # ) | ||
| # | ||
| # def _TKN(self): | ||
| # tkn = ( | ||
| # self.conc_mass_comp["S_NH4"] | ||
| # + self.conc_mass_comp["S_ND"] | ||
| # + self.conc_mass_comp["X_ND"] | ||
| # + self.params.i_xb | ||
| # * (self.conc_mass_comp["X_BH"] + self.conc_mass_comp["X_BA"]) | ||
| # + self.params.i_xp | ||
| # * (self.conc_mass_comp["X_P"] + self.conc_mass_comp["X_I"]) | ||
| # ) | ||
| # return tkn | ||
| # | ||
| # self.TKN = pyo.Expression( | ||
| # rule=_TKN, | ||
| # doc="Total Kjeldahl Nitrogen", | ||
| # ) | ||
| # | ||
| # def _Total_N(self): | ||
| # totaln = self.TKN + self.conc_mass_comp["S_NOX"] | ||
| # return totaln | ||
| # | ||
| # self.Total_N = pyo.Expression( | ||
| # rule=_Total_N, | ||
| # doc="Total Nitrogen", | ||
| # ) |
There was a problem hiding this comment.
This is the only missing piece according to Chenyu. Should just need to identify these equations in literature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: