A bare-bones subtypes implementation #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempts to carry out the smallest subset of changes required to achieve this. Tests updated accordingly.
|
@hedss No disrespect at all, I was working on a side project with this, but clearly stopped a while ago. I do hope to get back to it someday, and if that is on top of your implementation then awesome! |
…d service. This allows service type enumeration to occur (allowing a node to determine all services published by the host). See the [DNS-SD RFC](https://tools.ietf.org/html/rfc6763#section-9) for more information.
Adds PTR records for `_services._dns-sd._udp.local` on every published service.
This allows a publisher to not only proxy hostnames for others, but also to advertise directly for another host. This is useful for systems where traffic forwarding is required.
Adds the ability to proxy addresses that aren't on the host interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
With no disrepect to @wesleytodd, I've made a smaller set of changes to enable sub-type publishing and discovery.
I believe the changes are suitable, and don't rely on any changes outside that of the
bonjourmodule. I'm more than happy to discuss this work and how we might go forwards with Wesley's implementation instead if need be, but I required something that worked 'quickly'.Tests updated and changes have been tested with both OSX's DNS-SD tools and Avahi.
Cheers!